Corrections for PIs. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l value. Modified Home page so only shows review of one week if on week 1. Also modified week paramemters to better represent summary view. Modified workout selections to be able to correctly allow for choice of day and week. Corrected function for calculationg current week.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 23.51% 24.39% +0.89%
==========================================
Files 67 67
Lines 3999 3887 -112
==========================================
+ Hits 940 948 +8
+ Misses 3059 2939 -120
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrections for PIs
Added Units to height, weight.
Modified startDate
On Home page did some changes. It now only shows two weeks if we are past week 1.
Also Changed the equation for calculating whether workout 1/2/3 is easy/medium/hard
Corrected function for calculating the current week.
Corrected workoutSelections so it will take in the chosen day and week from workoutHome.
📚 Documentation
This link below seems to be dead.
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.
✅ Testing
Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: